Expose future stub on Pinecone connection #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanshah18
reviewed
Oct 3, 2023
rohanshah18
reviewed
Oct 3, 2023
|
@russcam Thanks for making the changes for async stub. I was successfully able to run the integration tests locally against your changes. I have left a comment for reverting the test file changes since I'm in plans of rewriting them. Once reverted, I'll approve your PR and we can merge the changes!! |
This commit exposes the future stub on Pinecone connection, allowing for non-blocking async calls
|
I've reverted the test changes @rohanshah18 |
rohanshah18
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit exposes the future stub on Pinecone connection, allowing for non-blocking async calls
Problem
PineconeConnection does not currently expose a stub for making asynchronous calls to the service. Async calls are very common in high traffic services.
Solution
Exposed the generated
VectorServiceGrpc.VectorServiceFutureStubonPineconeConnection. This returnscom.google.common.util.concurrent.ListenableFuture<V>for each call, which allows chaining of asynchronous operations.The PR also removes an unused public method,
setBlockingStub; can add this back if client API compatibility dictates.Type of Change
Test Plan
Run
sanityAsyncFuturetest